Skip to content

fix: distance measure in non llm CR #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: distance measure in non llm CR #1787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/ragas/metrics/_context_recall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from pydantic import BaseModel

from ragas.dataset_schema import SingleTurnSample
from ragas.metrics._string import NonLLMStringSimilarity
from ragas.metrics._string import DistanceMeasure, NonLLMStringSimilarity
from ragas.metrics.base import (
MetricOutputType,
MetricType,
Expand Down Expand Up @@ -210,19 +210,23 @@ class NonLLMContextRecall(SingleTurnMetric):
}
)
output_type: MetricOutputType = MetricOutputType.CONTINUOUS
distance_measure: SingleTurnMetric = field(
_distance_measure: SingleTurnMetric = field(
default_factory=lambda: NonLLMStringSimilarity()
)
threshold: float = 0.5

def __post_init__(self):
if isinstance(self.distance_measure, MetricWithLLM):
raise ValueError(
"distance_measure must not be an instance of MetricWithLLM for NonLLMContextPrecisionWithReference"
)

def init(self, run_config: RunConfig) -> None: ...

@property
def distance_measure(self) -> SingleTurnMetric:
return self._distance_measure

@distance_measure.setter
def distance_measure(self, distance_measure: DistanceMeasure) -> None:
self._distance_measure = NonLLMStringSimilarity(
distance_measure=distance_measure
)

async def _single_turn_ascore(
self, sample: SingleTurnSample, callbacks: Callbacks
) -> float:
Expand Down
Loading