Skip to content

Avoid unnecessary decompose_claims call when mode='precision' in _factual_correctness.py #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dfhssilva
Copy link
Contributor

Avoid unnecessary decompose_claims call when mode='precision' in FactualCorrectness.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 13, 2024
@shahules786 shahules786 self-requested a review November 14, 2024 04:05
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @dfhssilva

@shahules786 shahules786 merged commit d4be4d6 into explodinggradients:main Nov 14, 2024
16 checks passed
shahules786 pushed a commit to shahules786/ragas that referenced this pull request Nov 14, 2024
…tual_correctness.py (explodinggradients#1669)

Avoid unnecessary decompose_claims call when mode='precision' in
FactualCorrectness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants