Skip to content

update AspectCritic docs examples #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

update AspectCritic docs examples #1547

merged 1 commit into from
Oct 22, 2024

Conversation

licux
Copy link
Contributor

@licux licux commented Oct 21, 2024

Update example codes in AspectCritic metrics to resolve "AssertionError: set LLM before use"

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 21, 2024
shahules786
shahules786 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)

@shahules786 shahules786 merged commit 849f3e3 into explodinggradients:main Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahules786 shahules786 shahules786 approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@licux @shahules786