bug fix: embeddings -> embedding

[starrywheat]

wrong spelling in embedding

[jjmachan]

Hey @starrywheat there seems to be a conflict here. Could you address that?

also are you there on Discord? would love to chat more there 🙂

[jjmachan]

Hey @starrywheat after thinking a bit more about it I think it's better with embeddings because the langchain base class is named embeddings. It's a minor detail but I feel it would avoid a small confusion down the line.

I'm closing this now but feel free to reopen with your reasons if you still feel that change is needed.

[starrywheat]

@jjmachan there is still bug unfixed.
The class variable self.embedding is not consistent in the script.
E.g. some of them are self.embeddings and some are self.embedding
Let's make them all to self.embeddings

[jjmachan]

ahh I see, my appologies then. I'm reopening this and we can work off this PR itself.

[starrywheat]

@jjmachan Thanks for reopening the PR.
I created the misspelling in the first place, so I feel like I have to fix it :)

And according to your suggestion, I have now use self.embeddings for all the variable name.
Latest updates: all checks passed !

[jjmachan]

Thank you @starrywheat for going through the trouble :)

[jjmachan]

Hey @starrywheat
Thank you so much for helping us improve ragas with your PR ❤️
Now since it's Christmas and all we wanted to send you a postcard and a couple of stickers as our way of saying thank you for your contribution. If you are interested could you shoot an email at jamesjithin97@gmail.com and I'll tell you more?

Cheers 🙂
Jithin