-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the space adventure task to the library. #61
base: master
Are you sure you want to change the base?
adding the space adventure task to the library. #61
Conversation
was this the wrong repository to add new tests? |
Yes! Apologies I missed your initial post - we were running a large, cross cloud performance study at the end of August and I didn't look at anything else. To answer your question - overall, yes, but if you want to contribute to expfactory.org you'll want to talk to @rwblair. For this repository, before we merge here you do need the preview url https://expfactory-experiments.github.io/space_adventure_pd to be actually live - do you want to add the experiment here? I can create a repository for you to PR to with the experiment files. |
It would be great if you could add the repository since we don't have a freely available preview of the test. Thank you. |
All set! https://github.com/expfactory-experiments/space_adventure_pd. You can take a look at the other respositories to get a sense of the organization. In summary - most of the experiment files you are adding here should go there, and then only the metadata is added in this PR. Ping me in an issue there if you have questions. And please expect my responses to not be immediate - I'm on travel until early October. |
I just uploaded the code to the new repo. |
Excellent! See if you can add some notes to the README, and then deploy the site to GitHub pages and put the URL in the description so a visitor can easily preview it. |
Done. I think. |
It looks great! 👾 You should now be able to update the PR here to remove the experiment assets (they are in the external repository) and just add the yaml that describes that location. |
We would like to contribute this probabilistic sequential decision-making task to the library.