-
Notifications
You must be signed in to change notification settings - Fork 42
Update inference API endpoints to use the new wormhole host URL #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe pull request updates the inference API documentation by replacing the base endpoint URL from models.exosphere.host to wormhole.exosphere.host across all API examples and references in the documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @NiveditJain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the accuracy of the inference API documentation by updating all relevant endpoint URLs. The change ensures that users are directed to the correct host for interacting with the inference services, thereby preventing potential connection errors and aligning the documentation with the latest infrastructure changes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the API endpoint host from models.exosphere.host to wormhole.exosphere.host in the documentation examples. The changes are consistent and address the goal of the PR. I've added a suggestion to consider using a placeholder for the base URL to improve the document's maintainability. One other thing to check: the example response on line 183 contains an output_url pointing to https://files.exosphere.host/.... For consistency with the other changes, especially the file upload endpoint, you may want to verify if this should also be updated to use wormhole.exosphere.host.
| This is the main API for running inference. This will send your data to the inference engine and start the inference process. Example request: | ||
| ```bash | ||
| curl -X POST https://models.exosphere.host/v0/infer/ \ | ||
| curl -X POST https://wormhole.exosphere.host/v0/infer/ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved maintainability, consider defining the base URL as a placeholder at the top of the document (e.g., HOST_URL=https://wormhole.exosphere.host) and reusing it throughout the examples (e.g., curl -X POST ${HOST_URL}/v0/infer/). This would centralize the host URL, making future updates much simpler and less prone to inconsistencies across the documentation.
No description provided.