fix: add path traversal validation to all server actions#65
Open
fix: add path traversal validation to all server actions#65
Conversation
Co-authored-by: NiveditJain <40313233+NiveditJain@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix path traversal vulnerability in server actions
fix: add path traversal validation to all server actions
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
"use server"actions acceptedprojectName/sessionId/agentIdwith no validation, allowing path traversal attacks whereprojectName = "../../etc"flows directly intojoin(projectsPath, projectName, sessionId + ".jsonl").Changes
lib/validate-params.ts— new shared validation utility mirroring the pattern already inapp/api/download/[project]/[session]/route.ts:validateProjectName()— rejects empty or path traversal sequences (..)validateSessionId()— enforces lowercase UUID formatvalidateAgentId()— rejects empty or path traversal sequences (agentIdis also used in file path construction viahashSubagentFile)11 server actions — validation injected at the top of each:
Tests:
__tests__/lib/validate-params.test.tscovering all three validatorscheck-eval-cache.test.tsandcheck-enrichment-cache.test.tsto use valid UUIDs and added validation-rejection test casesType of Change
Checklist
npm run lintpassesnpx tsc --noEmitpassesnpm run test:runpassesnpm run buildsucceedsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.