Esp2866 update #24
Open
Esp2866 update #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadpol
approved these changes
Nov 20, 2017
| #ifdef SL_DRIVER_VERSION | ||
| client->sslConnect(serverName,443); | ||
| #if defined(ESP8266) | ||
| client->connect(serverName,443); |
There was a problem hiding this comment.
We need to fix the hardcoding of the port number. But not in this PR.
|
Do not Merge this branch with Master! ESP8266 secure connection functionality has been added in PR #25 |
elijordan
reviewed
Jun 27, 2018
| client->stop(); | ||
| #ifdef SL_DRIVER_VERSION | ||
| client->sslConnect(serverName,443); | ||
| #if defined(ESP8266) |
There was a problem hiding this comment.
Needs to be changed to:
#elif (ESP8266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.