Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: use brutasse fancy borders #73

Closed
wants to merge 1 commit into from
Closed

table: use brutasse fancy borders #73

wants to merge 1 commit into from

Conversation

greut
Copy link
Contributor

@greut greut commented Dec 3, 2018

thanks to @brutasse we can have nicer corners.

% exo firewall list        
┌───────────┬────────────────────────┬──────────────────────────────────────┐
│   NAME    │      DESCRIPTION       │                  ID                  │
├───────────┼────────────────────────┼──────────────────────────────────────┤
│ exokube   │ Created by exo CLI     │ a9a3878c-9e32-40f8-9a17-80dc34f01f7b │
│ default   │ Default Security Group │ 21a14a60-be48-4bde-8509-ae6ed0231ed0 │
│ wide-open │ dummy (for test)       │ 4bfe1073-a6d4-48bd-8f24-2ab586674092 │
│ exoip     │                        │ 2a18a678-8e5a-4cd5-8948-b3ba51c94a55 │
└───────────┴────────────────────────┴──────────────────────────────────────┘

table: use brutasse fancy borders
81661c1 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut added the enhancement New feature or request label Dec 3, 2018
@pierre-emmanuelJ
Copy link
Member

Thanks @brutasse awesome 👍

brutasse
brutasse approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@brutasse brutasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊 😊 😊

chrisglass
chrisglass approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@chrisglass chrisglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh nice!

pierre-emmanuelJ
pierre-emmanuelJ approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕷

@greut greut added the HOLD ✋ Hold, don't merge label Dec 14, 2018
@falzm
Copy link
Contributor

falzm commented Jan 9, 2020

This one has reached the point where it's unlikely we'll ever merge it: so long, and thanks for all the 🐠

@falzm falzm closed this Jan 9, 2020
@falzm falzm deleted the tablewriter branch January 9, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisglass chrisglass chrisglass approved these changes

@brutasse brutasse brutasse approved these changes

@pierre-emmanuelJ pierre-emmanuelJ pierre-emmanuelJ approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request HOLD ✋ Hold, don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@greut @pierre-emmanuelJ @falzm @chrisglass @brutasse