Skip to content

regression: non-numeric path parameter raises on Rails #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

regression: non-numeric path parameter raises on Rails #226

merged 1 commit into from
Apr 22, 2024

Conversation

@exoego
Copy link
Owner

@exoego exoego commented Apr 22, 2024 •
edited
Loading

Part of #224

Note that Hanami implementation is still broken.
spec/apps/hanami/doc/openapi.(json|yaml) should have /sites/{name} path, but /sites/abc123 and /sites/no-such instead.

@exoego exoego added the bug Something isn't working label Apr 22, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 22, 2024
View reviewed changes
@exoego exoego changed the title regression: non-numeric path parameter causes error in Rails regression: non-numeric path parameter raises error on Rails Apr 22, 2024
@exoego exoego changed the title regression: non-numeric path parameter raises error on Rails regression: non-numeric path parameter raises on Rails Apr 22, 2024
@codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (2444e40) to head (b02d423).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   97.11%   97.08%   -0.03%     
==========================================
  Files          20       20              
  Lines         623      618       -5     
  Branches      143      142       -1     
==========================================
- Hits          605      600       -5     
  Misses         18       18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego merged commit 82c634e into master Apr 22, 2024
@exoego exoego deleted the non-numeric-id branch April 22, 2024 01:59
@exoego exoego changed the title regression: non-numeric path parameter raises on Rails regression: non-numeric path parameter raises on Rails (Hanami is still broken) Apr 22, 2024
@exoego exoego mentioned this pull request Apr 22, 2024
Closed
@exoego exoego changed the title regression: non-numeric path parameter raises on Rails (Hanami is still broken) regression: non-numeric path parameter raises on Rails Apr 22, 2024
@exoego exoego added this to the vnext milestone Apr 22, 2024
@exoego exoego mentioned this pull request Nov 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

v0.18.2

Development

Successfully merging this pull request may close these issues.

2 participants

@exoego