-
Notifications
You must be signed in to change notification settings - Fork 68
Generate multiple examples #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@exoego take a look, please |
I am fine with the How does this handle when some test cases have
I don't get the concern. |
@AlexeyMatskevich |
@rhiroe Hi, this is a conceptual question for me so far. We realize what we want to solve is to provide some sample examples so that the reader of the documentation can see some cases, which is some hack of OpenAPI limitations. However, how to achieve this is a complex issue where we need to think about design. Maybe the author (@exoego ) will have an opinion (sorry I ignored your question before) p.s. I may have already forgotten my context on this issue. |
@AlexeyMatskevich In my personal opinion,
For the ones we don't want to include, I think adding
Our team solves this by setting a fixed seed value when the OPENAPI environment variable is present. RSpec.configure do |config|
config.seed = 1 if ENV['OPENAPI'] |
I tried to do the generation of a few examples as described here. I would like to get a review of my approach before I continue working on this feature.
The very design of this feature is also questionable, perhaps it makes sense to use the feature in roughly this way for simpler cases:
In other cases I am concerned about the definition of unique examples, do I need to remove non-unique examples, or should I keep all examples? Maybe both options are needed for flexibility 🤔