Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Fixes for Delphi 12 #128

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Warning Fixes for Delphi 12 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47bacaf
Removed ifdef DisposeOf and added default Result for createinstance, …
RyanTMontoya Mar 29, 2024
6adee9c
better default value for result, removed mistaken understanding of Cr…
RyanTMontoya Mar 29, 2024
787bcbd
Adjusted compiler condition for 12 and up to be compatible with old c…
RyanTMontoya Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Quick.RTTI.Utils.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ class function TRTTI.CreateInstance<T>(const Args: array of TValue): T;
rmethod: TRttiMethod;
rinstype: TRttiInstanceType;
begin
Result := Default(T);
rtype := fCtx.GetType(TypeInfo(T));
for rmethod in rtype.GetMethods do
begin
Expand Down
2 changes: 1 addition & 1 deletion Quick.Threads.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ procedure TThreadedQueueCS<T>.Clear;
try
for obj in FQueue do
begin
if TypeInfo(T) = TypeInfo(TObject) then PObject(@obj){$IFNDEF FPC}.DisposeOf;{$ELSE}.Free;{$ENDIF}
if TypeInfo(T) = TypeInfo(TObject) then PObject(@obj){$ifndef FPC}{$IFDEF DELPHIRX12_UP}.Free{$ELSE}.DisposeOf{$ENDIF}{$ELSE}.Free{$ENDIF};
end;

SetLength(FQueue,0);
Expand Down