Simplify track creation #6991
Merged
Simplify track creation #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
reviewed
Jul 17, 2024
ErikSchierboom
commented
Jul 18, 2024
|
|
||
| private | ||
| def safe_directory_already_set? | ||
| Kernel.system("git config --global --get safe.directory #{safe_directory}") |
There was a problem hiding this comment.
According to the docs, system will return true when the exit code is 0, and false when it isn't zero. And conveniently, the git command returns 1 when the safe directory isn't set, and 0 when it is
iHiD
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, one can just pass in a track's slug to create a new track (as opposed to passing in the repo url).
It also adds the track directory to the git safe directories list, and the triggers a new deploy, which is needed for the permissions to apply.