Add correct links and boolean #6202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, lazyload donation form
…an up types, clean up imports
iHiD
added a commit
that referenced
this pull request
Sep 21, 2023
* Add donation modal * Make further styling on Donation step modal, make it accessible, wider, lazyload donation form * Replace button classes, add inline drop-shadow * Fix Graphical icon types * Add links to student mentoring session * Wire in donatins links * Refreshing tests - WIP * Minor changes * Fix ruby test * Fix other ruby test * Populate captcha information * Remove unused code * Fix tests * Add correct links and boolean (#6202) * Reorganise MentoringSession's donation data (#6206) * Reorganise MentoringSession's donation data * Update mentoring_session_test * Pass down camelized data * Pass donation data down to sidepanel modal initiator * Improve layout and copy * Clean up DonationStep.tsx * Add logic around when to show modal * Prevent the modal from closing when the overlay is clicked * Further donation modal tweaks (#6214) * Change button text, remove static booleans * Change default values * Update celebration text * Update celebration step * Update urls * Use confirmParamsReturnUrl everywhere * Add successfulDonationStep * Update xstate * Change width of SuccessfulDonationStep's container modal * Change nyan cat height * Change continue text * Apply suggestions from code review * Update test * Remove recaptcha sitekey * Change text in test * Fix more tests * Update app/models/user.rb Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com> * Update initialData types, Remove unnecessary else * Remove wizard-hat * Remove unused filter, undo negating boolean * Update user_test * Update app/helpers/react_components/student/mentoring_session.rb Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com> * Update .github/labels.yml * Update CODE_OF_CONDUCT.md * Sync yarn.lock and package.json * Update link name, simplify link types, unify same types --------- Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.