Fix the world #5861
Merged
Fix the world #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
commented
Aug 7, 2023
| paymentIntentType === 'payment' ? handlePaymentSubmit : handleSubmit | ||
| } | ||
| > | ||
| <form data-turbo="false" onSubmit={handlePaymentSubmit}> |
There was a problem hiding this comment.
You can get rid of handleSubmit entirely now, and probably a whole ton of unused code
iHiD
pushed a commit
that referenced
this pull request
Aug 8, 2023
Adjust tests, update TS, add return links, refactor, etc Sort out setup_future_usage issue Remove unused bits, tailor other bits Add appearance obj Add different theme objects DRY Use card element for subscriptions, refactor things Fix a wrong type Update import Adjust tests Fix things, and paths Fix footer form anomaly Improve TS on application.tsx Add stripe version to footer cache key Fix test Force dark colors on premium and insiders Refactor things, make card element options adaptive Format utils better Pass amount from backend Delete unused component Lazy load stripe.js (#5843) Add styling for load error and loading Tweak margins Fix the world (#5861) * Fix the world * Tidy up, optimise ExercismStripeElements * Tidy up StripeForm * add off_session on Stripe::Subscription.create * Refactor Form, useStripeForm * Leave things at a simple, working state * Fix tests * One more fix --------- Co-authored-by: dem4ron <demaaron88@gmail.com>
iHiD
pushed a commit
that referenced
this pull request
Aug 8, 2023
Adjust tests, update TS, add return links, refactor, etc Sort out setup_future_usage issue Remove unused bits, tailor other bits Add appearance obj Add different theme objects DRY Use card element for subscriptions, refactor things Fix a wrong type Update import Adjust tests Fix things, and paths Fix footer form anomaly Improve TS on application.tsx Add stripe version to footer cache key Fix test Force dark colors on premium and insiders Refactor things, make card element options adaptive Format utils better Pass amount from backend Delete unused component Lazy load stripe.js (#5843) Add styling for load error and loading Tweak margins Fix the world (#5861) * Fix the world * Tidy up, optimise ExercismStripeElements * Tidy up StripeForm * add off_session on Stripe::Subscription.create * Refactor Form, useStripeForm * Leave things at a simple, working state * Fix tests * One more fix --------- Co-authored-by: dem4ron <demaaron88@gmail.com> Fix bad rebase
iHiD
pushed a commit
that referenced
this pull request
Aug 8, 2023
Adjust tests, update TS, add return links, refactor, etc Sort out setup_future_usage issue Remove unused bits, tailor other bits Add appearance obj Add different theme objects DRY Use card element for subscriptions, refactor things Fix a wrong type Update import Adjust tests Fix things, and paths Fix footer form anomaly Improve TS on application.tsx Add stripe version to footer cache key Fix test Force dark colors on premium and insiders Refactor things, make card element options adaptive Format utils better Pass amount from backend Delete unused component Lazy load stripe.js (#5843) Add styling for load error and loading Tweak margins Fix the world (#5861) * Fix the world * Tidy up, optimise ExercismStripeElements * Tidy up StripeForm * add off_session on Stripe::Subscription.create * Refactor Form, useStripeForm * Leave things at a simple, working state * Fix tests * One more fix --------- Co-authored-by: dem4ron <demaaron88@gmail.com> Fix bad rebase
iHiD
pushed a commit
that referenced
this pull request
Aug 9, 2023
Adjust tests, update TS, add return links, refactor, etc Sort out setup_future_usage issue Remove unused bits, tailor other bits Add appearance obj Add different theme objects DRY Use card element for subscriptions, refactor things Fix a wrong type Update import Adjust tests Fix things, and paths Fix footer form anomaly Improve TS on application.tsx Add stripe version to footer cache key Fix test Force dark colors on premium and insiders Refactor things, make card element options adaptive Format utils better Pass amount from backend Delete unused component Lazy load stripe.js (#5843) Add styling for load error and loading Tweak margins Fix the world (#5861) * Fix the world * Tidy up, optimise ExercismStripeElements * Tidy up StripeForm * add off_session on Stripe::Subscription.create * Refactor Form, useStripeForm * Leave things at a simple, working state * Fix tests * One more fix --------- Co-authored-by: dem4ron <demaaron88@gmail.com> Fix bad rebase
iHiD
added a commit
that referenced
this pull request
Aug 9, 2023
* WIP * WIP * WIP * More WIP * Fix things * Add custom input (#5863) * Add custom input * Add conditionals * WIP * Fix things * First working iteration Adjust tests, update TS, add return links, refactor, etc Sort out setup_future_usage issue Remove unused bits, tailor other bits Add appearance obj Add different theme objects DRY Use card element for subscriptions, refactor things Fix a wrong type Update import Adjust tests Fix things, and paths Fix footer form anomaly Improve TS on application.tsx Add stripe version to footer cache key Fix test Force dark colors on premium and insiders Refactor things, make card element options adaptive Format utils better Pass amount from backend Delete unused component Lazy load stripe.js (#5843) Add styling for load error and loading Tweak margins Fix the world (#5861) * Fix the world * Tidy up, optimise ExercismStripeElements * Tidy up StripeForm * add off_session on Stripe::Subscription.create * Refactor Form, useStripeForm * Leave things at a simple, working state * Fix tests * One more fix --------- Co-authored-by: dem4ron <demaaron88@gmail.com> Fix bad rebase * Fix flow * Tweak tweak tweak * Add icons * Show error on blur (#5865) * Improvements * Fix missing import * Fix mismatch * Fix breaking StripeElementAmount * Tweak insiders page copy * Remove final references to Premium --------- Co-authored-by: Aron Demeter <66035744+dem4ron@users.noreply.github.com> Co-authored-by: dem4ron <demaaron88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.