Configure CSS nesting correctly #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
reviewed
Feb 15, 2023
| @@ -1,7 +1,7 @@ | |||
| module.exports = { | |||
| plugins: [ | |||
| require('postcss-import'), | |||
| require('tailwindcss/nesting'), | |||
| require('tailwindcss/nesting')(require('postcss-nesting')), | |||
There was a problem hiding this comment.
following the docs you'd need to write it in an object format like this:
// postcss.config.js
module.exports = {
plugins: {
'postcss-import': {},
'tailwindcss/nesting': 'postcss-nesting',
tailwindcss: {},
autoprefixer: {},
}
}but as it was already configured in this commonjs format, this is just the analogue of the above. It invokes the required tailwindcss/nesting plugin with the required postcss-nesting plugin as an argument.
dem4ron
force-pushed
the
nested-css-setup
branch
from
2081773 to
1d6295a
Compare
ErikSchierboom
approved these changes
Feb 15, 2023
yes |
ErikSchierboom
added a commit
that referenced
this pull request
Feb 17, 2023
This reverts commit d88930e.
ErikSchierboom
added a commit
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.