Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mentor bio for setn4me #1308

Merged
merged 4 commits into from
Sep 25, 2019
Merged

Add mentor bio for setn4me #1308

merged 4 commits into from
Sep 25, 2019

Conversation

setn4me
Copy link
Contributor

@setn4me setn4me commented Sep 21, 2019

No description provided.

Copy link
Member

@NobbZ NobbZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general your part of this PR looks good, though missindended because of the odd indend of the other entries.

Would you mind re-indenting everything with an indentlevel of 2 spaces?

Copy link
Member

@rpottsoh rpottsoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening { and closing } should be at the same level of indentation.

Co-Authored-By: Ryan Potts <rpottsoh@users.noreply.github.com>
Copy link
Member

@rpottsoh rpottsoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind terribly making one more commit? The indentation level on lines 2 through 9, each line there needs to have one leading space removed. Also, line 25 needs the same adjustment.

I see that I have re-iterated what @NobbZ already asked for.

@rpottsoh
Copy link
Member

Thanks for making the change I requested before. I hadn't looked at the entire file before now. I apologize for that.

@rpottsoh rpottsoh dismissed their stale review September 25, 2019 18:50

Other changes need to be made, not part of this review, before merging can happen

@setn4me
Copy link
Contributor Author

setn4me commented Sep 25, 2019

No problem! I am new to Git, so I have some misunderstandings.

@rpottsoh rpottsoh merged commit 5cdd045 into exercism:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants