Add mentoring notes for the elisp two-fer exercise #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ------- I find the mentoring notes invaluable in providing consistent feedback to students however the elisp track has none. It's by no means meant as an authoritative "The exercise MUST be done this way", but rather distills some of the most repeated points I've delivered in the past few weeks #contributions-welcome
Co-Authored-By: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
|
Many thanks for the review and suggestions @SleeplessByte ! |
|
There are no members in @exercism/website-copy-elisp. Could therefore one of @exercism/website-copy-common-lisp, @exercism/website-copy-scheme, @exercism/website-copy-clojure, or @exercism/website-copy-lfe confirm if these mentoring notes seem reasonable from your point of view? I think it is safe to merge in 48 hours if no one vetos. |
verdammelt
approved these changes
Oct 1, 2019
|
Thank you for the review @verdammelt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I find the mentoring notes invaluable in providing consistent feedback
to students however the elisp track has none. It's by no means meant
as an authoritative "The exercise MUST be done this way", but rather
distills some of the most repeated points I've delivered in the past
few weeks #contributions-welcome