Skip to content

Exercise/resistor color trio #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

rodmagaldi
Copy link
Contributor

I implemented the resistor-color-trio exercise based on the contributing guidelines.

However, I did not understand point 13 of the guideline:

  1. Create an entry in config.json: a unique new UUID (you can use the configlet uuid tool to generate one, scroll down to tools to see how you can get it), give it a difficulty (should be similar to similar exercises), and make sure the order of the file is sane. Currently the file is ordered first on core - non core, then on difficulty low to high, and finally lexographically.

Is there anything that needs to be done as to that? I looked around in other exercises and there didn't seem to be anything else.

Also, let me know if you catch any mistakes I might have made 😆

Thanks!

@SleeplessByte
Copy link
Member

Hi @rodmagaldi,

Great stuff. That part in the doc is talking about this file, and section. Can you add this new exercises to this list?

@rodmagaldi
Copy link
Contributor Author

Hey @SleeplessByte ! I added the new exercise to the json file.

Anything else to be done here ?

@SleeplessByte
Copy link
Member

So sorry @rodmagaldi ! I was swamped with work and then cleared my Notifications and completely missed this.

@SleeplessByte SleeplessByte added x:size/large Large amount of work new exercise ✨ Adding an exercise from the canonical data labels Dec 14, 2021
@SleeplessByte SleeplessByte merged commit e4de99a into exercism:main Dec 14, 2021
@rodmagaldi
Copy link
Contributor Author

No worries @SleeplessByte ! Just glad to see my name in the contributors page 😄

Thanks !

@SleeplessByte
Copy link
Member

Do you have Twitter? I wanna shout you out

@rodmagaldi
Copy link
Contributor Author

Do you have Twitter? I wanna shout you out

@magaldi_rodrigo

@SleeplessByte
Copy link
Member

Nice. I'll tweet it out once it shows on my feed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new exercise ✨ Adding an exercise from the canonical data x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants