Skip to content

Update all GHA workflows #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions common/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,15 @@
"Atomics": "readonly",
"SharedArrayBuffer": "readonly"
},
"plugins": [
"@typescript-eslint"
],
"plugins": ["@typescript-eslint"],
"rules": {
// Code style not forced upon the student
"@typescript-eslint/array-type": "off",

// Prevent bugs
"@typescript-eslint/explicit-function-return-type": [
"warn", {
"warn",
{
"allowExpressions": false,
"allowTypedFunctionExpressions": true,
"allowHigherOrderFunctions": true
Expand All @@ -45,7 +44,8 @@
"@typescript-eslint/indent": "off",

"@typescript-eslint/no-inferrable-types": [
"error", {
"error",
{
"ignoreParameters": true
}
],
Expand All @@ -56,31 +56,37 @@
// Code style not forced upon the student
"@typescript-eslint/no-non-null-assertion": "off",

// Only disallow readonly without an access modifier
// Only disallow readonly without an access modifier
"@typescript-eslint/no-parameter-properties": [
"warn", {
"warn",
{
"allows": [
"private", "protected", "public",
"private readonly", "protected readonly", "public readonly"
"private",
"protected",
"public",
"private readonly",
"protected readonly",
"public readonly"
]
}
],

// Covered by the tsc compiler (noUnusedLocals)
"@typescript-eslint/no-unused-vars": "off",

// Prevent bugs, not styling
// Prevent bugs, not styling
"@typescript-eslint/no-use-before-define": [
"error", {
"error",
{
"functions": false,
"typedefs": false
}
],

// Always disable base-rule
// Always disable base-rule
"semi": "off",

// Code style not forced upon student
// Code style not forced upon student
"@typescript-eslint/semi": "off"
}
}
Loading