Skip to content

Conversation

@yura
Copy link
Contributor

@yura yura commented Nov 29, 2025

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions
Copy link
Contributor

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@github-actions github-actions bot closed this Nov 29, 2025
@yura
Copy link
Contributor Author

yura commented Nov 29, 2025

Wrong PR contents, sorry. Need just 61ea70a commit

@Sencudra
Copy link
Contributor

Sencudra commented Nov 29, 2025

@yura Unfortunately, this not what expected to be done here.

You cannot just change expected result, because it's coming from canonical-data json file which is shared across all exercism tracks.

Moreover, you cannot just chage *Tests.swift file, because all of them are generated from template.swift. And even if you try to modify the template you would find out that there is no test data at all. It's all got from canonical-data repo.

So, what is needed to be done here is to modify closures for foldl in template (and verify other functions) to work as it is expected in canonical-data. And it's expects { element / accumulator }. And then you need also to fix .meta/*Example.swift solution for CI tests to pass.

Feel free to ask any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants