Error in pizza slices test

[rhoot]

The tests in the pizza-slices exercise has:

swift/exercises/concept/pizza-slices/Tests/PizzaSlicesTests/PizzaSlicesTests.swift

Lines 71 to 72 in 4dea7e2

	let biggest = biggestSlice(diameterA: "0", slicesA: "8", diameterB: "16 inches", slicesB: "8")
	XCTAssertEqual(biggest, "Slice A is bigger")

First of all, I would have assumed that a pizza with a diameter of 0 is no pizza. But even if we consider that such a pizza might exist: A pizza with a diameter of 0 couldn't possibly have a larger per-slice area than a slice of a pizza with a diameter of 16", regardless of how many slices you cut the second pizza into.

[meatball133]

The idea here is that "16 inches" is a faulty input, meaning that pizza is an error. Even a pizza with a size of 0 is bigger than a pizza with an error. It is a bit confusing, I am currently doing quite a big update to the track currently. I might rewatch this exercise, or might just remove that test case. We will see.

[BNAndras]

If the pizza is less than an inch in diameter, it might be appropriate to round down and say it’s zero inches. In that case, that pizza is still valid. The instructions should still make this clear to the student though.