ensure-stubs-compile: continue early if allowed not to compile #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strictly speaking this should have been done ever since #483, but it wasn't necessary then because touching a file doesn't impose any costs. But if we were to impose additional work on ensure-stubs-compile, then we would actually want to do this. This commit paves the way for future additions to this script.
coriolinus
approved these changes
Apr 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly speaking this should have been done ever since #483, but it
wasn't necessary then because touching a file doesn't impose any costs.
But if we were to impose additional work on ensure-stubs-compile, then
we would actually want to do this. This commit paves the way for future
additions to this script.