Skip to content

ensure-stubs-compile: Deny warnings in stubs #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2018
Merged

ensure-stubs-compile: Deny warnings in stubs #478

merged 1 commit into from
Apr 8, 2018

Conversation

petertseng
Copy link
Member

No description provided.

@petertseng
Copy link
Member Author

(note that the touch $dir/src/lib.rs is now no longer necessary, since the sed causes the stub to have been modified)

@coriolinus
Copy link
Member

Good point. You're the author of this PR, so you should feel free to adjust it as required; my intent was simply to eliminate the merge conflict so we could see if the checks would now pass.

Copy link
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that once #497 is merged, restarting Travis on this will cause it to go green. Once that happens, we should merge this.

@coriolinus
Copy link
Member

Oops: of course merging #497 hasn't changed this PR's Travis results, because this will need to be rebased onto the current head of master for that to work.

@petertseng
Copy link
Member Author

eh, any sort of rebase to make travis make a new merge commit; it just doesn't do that if the commit has already been tested. I wonder if there's a way. But rebasing on master's the most natural way anyway, since it's the most likely thing anyone would do for any other reason

@coriolinus coriolinus merged commit daf71e9 into exercism:master Apr 8, 2018
@petertseng petertseng deleted the warnstubs branch April 8, 2018 23:29
@petertseng petertseng changed the title WIP: ensure-stubs-compile: Deny warnings in stubs ensure-stubs-compile: Deny warnings in stubs Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants