Skip to content

Remove variables that start with an underscore #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions exercises/diffie-hellman/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
pub fn private_key(_p: u64) -> u64 {
unimplemented!()
pub fn private_key(p: u64) -> u64 {
unimplemented!("Pick a private key greater than 1 and less than {}", p)
}

pub fn public_key(_p: u64, _g: u64, _a: u64) -> u64 {
unimplemented!()
pub fn public_key(p: u64, g: u64, a: u64) -> u64 {
unimplemented!("Calculate public key using prime numbers {} and {}, and private key {}", p, g, a)
}

pub fn secret(_p: u64, _b_pub: u64, _a: u64) -> u64 {
unimplemented!()
pub fn secret(p: u64, b_pub: u64, a: u64) -> u64 {
unimplemented!("Calculate secret key using prime number {}, public key {}, and private key {}", p, b_pub, a)
}
4 changes: 2 additions & 2 deletions exercises/isbn-verifier/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// Determines whether the supplied string is a valid ISBN number
pub fn is_valid_isbn(_isbn: &str) -> bool {
unimplemented!();
pub fn is_valid_isbn(isbn: &str) -> bool {
unimplemented!("Is {:?} a valid ISBN number?", isbn);
}
4 changes: 2 additions & 2 deletions exercises/series/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pub fn series(_digits: &str, _len: usize) -> Vec<String> {
unimplemented!()
pub fn series(digits: &str, len: usize) -> Vec<String> {
unimplemented!("What are the series of length {} in string {:?}", len, digits)
}