Skip to content

Swaps all _ only parameters for input #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/alphametics/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use std::collections::HashMap;

pub fn solve(_: &str) -> Option<HashMap<char, u8>> {
unimplemented!()
pub fn solve(input: &str) -> Option<HashMap<char, u8>> {
unimplemented!("Solve the alphametic {:?}", input)
}
4 changes: 2 additions & 2 deletions exercises/book-store/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pub fn lowest_price(_: &[usize]) -> usize {
unimplemented!()
pub fn lowest_price(books: &[usize]) -> usize {
unimplemented!("Find the lowest price of the bookbasket with books {:?}", books)
}
4 changes: 2 additions & 2 deletions exercises/crypto-square/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pub fn encrypt(_: &str) -> String {
unimplemented!()
pub fn encrypt(input: &str) -> String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this being input.

Another possibility I would accept is plaintext.

unimplemented!("Encrypt {:?} using a square code", input)
}
4 changes: 2 additions & 2 deletions exercises/decimal/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pub struct Decimal {
}

impl Decimal {
pub fn try_from(_: &str) -> Option<Decimal> {
unimplemented!()
pub fn try_from(input: &str) -> Option<Decimal> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm OK with input here too.

unimplemented!("Create a new decimal with a value of {}", input)
}
}
4 changes: 2 additions & 2 deletions exercises/poker/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
///
/// Note the type signature: this function should return _the same_ reference to
/// the winning hand(s) as were passed in, not reconstructed strings which happen to be equal.
pub fn winning_hands<'a>(_: &[&'a str]) -> Option<Vec<&'a str>> {
unimplemented!()
pub fn winning_hands<'a>(hands: &[&'a str]) -> Option<Vec<&'a str>> {
unimplemented!("Out of {:?}, which hand wins?", hands)
}