Skip to content

Remove unused variable from Alphametics stub #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

coriolinus
Copy link
Member

Travis fails in general right now, because we have an unused variable in the Alphametics stub. This is causing #381 to fail right now, and possibly others.

This simply removes the unused name from the Alphametics stub. This changes no interfaces or tests; students may rename the variable to anything they prefer. It simply ensures that the _test/ensure-stubs-compile.sh test actually passes.

@coriolinus coriolinus merged commit 0a97c1a into exercism:master Nov 7, 2017
@coriolinus coriolinus deleted the alphametics-remove-unused-variable-name branch November 7, 2017 18:46
@petertseng
Copy link
Member

I support this change.

I strongly believe this is not the reason #381 fails, if #381 preserved existing behaviour.

Stubs are never compiled with [deny(warnings)] in current tests. If #381 fails, then #381 did not preserve that behaviour and instead represents a change in behaviour.

@coriolinus
Copy link
Member Author

coriolinus commented Nov 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants