An equilateral triangle is a special case of an isosceles triangle. #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Much appreciated. The Rust implementation of the triangle exercise follows the current canonical test suite, which doesn't do these sorts of tests. Instead of changing only our tests, I suggest a PR against the standard test suite. If that PR is merged, then all tracks that implement the Triangles can improve their tests. |
|
@elahn I started a conversation on the topic here: exercism/problem-specifications#379 |
|
This should be reopened now, right? |
|
I'd like to wait for the PR in x-common to get merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An isosceles triangle is a triangle with (at least) two equal sides. A triangle with all sides equal is called an equilateral triangle, and a triangle with no sides equal is called a scalene triangle. An equilateral triangle is therefore a special case of an isosceles triangle having not just two, but all three sides and angles equal.
http://mathworld.wolfram.com/IsoscelesTriangle.html