-
-
Notifications
You must be signed in to change notification settings - Fork 526
Use progression from Go #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These exercises was on the Go track, but isn't present in the Ruby track: * bank-account * error-handling * parallel-letter-frequency * tree-building
6fbaaf5
to
5467cf0
Compare
Awesome, This looks great. Thanks! |
config.json
Outdated
@@ -6,854 +6,1157 @@ | |||
"solution_pattern": "[Ee]xample|\\.meta/solutions/[^/]*\\.rb", | |||
"exercises": [ | |||
{ | |||
"slug": "hello-world", | |||
"uuid": "4fe19484-4414-471b-a106-73c776c61388", | |||
"slug": "gigasecond", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exercise order within this array used to be significant in V1.
Unless this has changed in V2 we probably need to keep the exercise ordering relatively consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done some more research and the order is still significant so I think I'd prefer to see the exercises keep the same order within the track for now.
If re-ordering is a good idea it should be handled in a separate PR.
Sorry if my suggestion of using the Go track has caused this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only things that should change are the
core
and unlocked_by
tags (and auto-approve
on hello world)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if my suggestion of using the Go track has caused this problem.
It has, but we'll figure it out. Although I do regret not writing a tool to handle this, now 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean I can merge #819 without causing you much trouble?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks ❤️
Let's hit the 'Go' button and see what happens.. |
This is an attempt at setting up the Ruby track as a nextercism track.
As suggested in #815 I have cloned the Go tracks progression, removing exercises that are Go-specific, preserving Ruby-only exercises as bonus exercises.
After this changes the progression tree looks like this:
The diff is probably slightly more complex than it needs to be as the order of exercises in the configs across Ruby and Go were slightly different.