Skip to content

Use progression from Go #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 27, 2018
Merged

Conversation

koppen
Copy link
Contributor

@koppen koppen commented Jul 27, 2018

This is an attempt at setting up the Ruby track as a nextercism track.

As suggested in #815 I have cloned the Go tracks progression, removing exercises that are Go-specific, preserving Ruby-only exercises as bonus exercises.

After this changes the progression tree looks like this:

Ruby
====

core
----
├─ hello-world
│  └─ space-age
│
├─ two-fer
│  ├─ leap
│  ├─ triangle
│  └─ proverb
│
├─ hamming
│  ├─ rna-transcription
│  └─ nucleotide-count
│
├─ raindrops
│  ├─ accumulate
│  ├─ roman-numerals
│  └─ strain
│
├─ scrabble-score
│  ├─ etl
│  └─ protein-translation
│
├─ isogram
│  ├─ pangram
│  ├─ anagram
│  ├─ word-count
│  └─ run-length-encoding
│
├─ difference-of-squares
│  ├─ sum-of-multiples
│  ├─ pythagorean-triplet
│  ├─ largest-series-product
│  ├─ nth-prime
│  └─ isbn-verifier
│
├─ luhn
│  ├─ crypto-square
│  ├─ atbash-cipher
│  ├─ simple-cipher
│  └─ rotational-cipher
│
├─ grains
│  ├─ secret-handshake
│  ├─ sieve
│  ├─ perfect-numbers
│  ├─ allergies
│  └─ all-your-base
│
├─ clock
│  ├─ phone-number
│  ├─ pig-latin
│  ├─ prime-factors
│  └─ meetup
│
├─ robot-name
│  ├─ palindrome-products
│  ├─ say
│  └─ wordy
│
├─ tournament
│  ├─ pascals-triangle
│  ├─ diamond
│  ├─ ocr-numbers
│  ├─ kindergarten-garden
│  ├─ poker
│  └─ bowling
│
├─ twelve-days
│  ├─ house
│  ├─ food-chain
│  └─ beer-song
│
├─ matrix
│  ├─ queen-attack
│  ├─ transpose
│  ├─ saddle-points
│  ├─ minesweeper
│  └─ connect

bonus
-----
gigasecond
bob
acronym
flatten-array
series
scale-generator
bracket-push
rail-fence-cipher
circular-buffer
custom-set
grade-school
simple-linked-list
linked-list
binary-search
binary-search-tree
robot-simulator
change
collatz-conjecture
book-store
dominoes
alphametics
two-bucket
list-ops
affine-cipher
complex-numbers
zipper

The diff is probably slightly more complex than it needs to be as the order of exercises in the configs across Ruby and Go were slightly different.

koppen added 5 commits July 27, 2018 12:21
These exercises was on the Go track, but isn't present in the Ruby track:

* bank-account
* error-handling
* parallel-letter-frequency
* tree-building
@Insti
Copy link
Contributor

Insti commented Jul 27, 2018

Awesome, This looks great. Thanks!

config.json Outdated
@@ -6,854 +6,1157 @@
"solution_pattern": "[Ee]xample|\\.meta/solutions/[^/]*\\.rb",
"exercises": [
{
"slug": "hello-world",
"uuid": "4fe19484-4414-471b-a106-73c776c61388",
"slug": "gigasecond",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exercise order within this array used to be significant in V1.
Unless this has changed in V2 we probably need to keep the exercise ordering relatively consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some more research and the order is still significant so I think I'd prefer to see the exercises keep the same order within the track for now.

If re-ordering is a good idea it should be handled in a separate PR.

Sorry if my suggestion of using the Go track has caused this problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only things that should change are the
core and unlocked_by tags (and auto-approve on hello world)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if my suggestion of using the Go track has caused this problem.

It has, but we'll figure it out. Although I do regret not writing a tool to handle this, now 😁

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean I can merge #819 without causing you much trouble?

Copy link
Contributor

@Insti Insti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks ❤️

@Insti
Copy link
Contributor

Insti commented Jul 27, 2018

Let's hit the 'Go' button and see what happens..

@Insti Insti merged commit 27bf007 into exercism:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants