Skip to content

Add phony target for test in Makefile #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tommyschaefer
Copy link
Contributor

Hi there!

I noticed while looking at the Travis CI output yesterday that the tests don't appear to be running.

From Travis CI log output:

$ make test
make: `test' is up to date.

The command "make test" exited with 0.

This is happening because we added a test directory, and the Makefile target is also named test.

If this looks good to you all and gets merged, I will rebase and push #514, #510, and #509 to run CI with the tests.

Thanks so much for your time!

@tommyschaefer
Copy link
Contributor Author

With this change the Travis CI log looks like this:

$ make test

----------------------------------------------------------------
running tests for: accumulate
Run options: --seed 16500

# Running:

.......

Finished in 0.001917s, 3652.0113 runs/s, 3652.0113 assertions/s.

7 runs, 7 assertions, 0 failures, 0 errors, 0 skips


----------------------------------------------------------------
running tests for: acronym
Run options: --seed 26000

# Running:

.......

Finished in 0.001685s, 4154.4654 runs/s, 4154.4654 assertions/s.

7 runs, 7 assertions, 0 failures, 0 errors, 0 skips


----------------------------------------------------------------

...

@tommyschaefer tommyschaefer changed the title Add phony target for test Add phony target for Makefile test target Dec 28, 2016
@tommyschaefer tommyschaefer changed the title Add phony target for Makefile test target Add phony target for test in Makefile Dec 28, 2016
@Insti
Copy link
Contributor

Insti commented Dec 28, 2016

Looks good @tommyschaefer, thanks. I really appreciate the detailed problem description/solution information you include in your PRs ❤️

For reference, documentation for Phony targets in make: https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html

@Insti Insti merged commit 7e2a779 into exercism:master Dec 29, 2016
@Insti
Copy link
Contributor

Insti commented Dec 29, 2016

Thanks. I didn't notice that I'd broken the tests when I created the test directory.
Sorry about that.

I was just glad that the tests of the exercise tests did not run needlessly all the time. So perhaps there is something there that can be improved. Only running the tests of the exercise tests when they have been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants