Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish Pythagorean Triplet because of missing instructions. #414

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

SimaDovakin
Copy link
Contributor

No description provided.

@BNAndras
Copy link
Member

@ErikSchierboom, if I recall correctly, this type of change affects the Exercism database and some manual work needs to be done to migrate the old slug to the new one. Is that correct?

iHiD
iHiD previously requested changes Feb 16, 2025
@SimaDovakin
Copy link
Contributor Author

I renamed directory name but now all test fails.

@SimaDovakin
Copy link
Contributor Author

I got it. I guess, I should change modules' names, too

@SimaDovakin SimaDovakin requested a review from iHiD February 16, 2025 18:01
@ErikSchierboom
Copy link
Member

Updating just the name is fine

@BNAndras
Copy link
Member

Mind adding yourself inside the contributors array to the exercise config as well? See https://exercism.org/docs/building/tracks/practice-exercises#h-file-meta-config-json for details.

@SimaDovakin
Copy link
Contributor Author

Mind adding yourself inside the contributors array to the exercise config as well? See https://exercism.org/docs/building/tracks/practice-exercises#h-file-meta-config-json for details.

Forgot about it, too)

@BNAndras
Copy link
Member

@iHiD, is this good to go? The UI won't let me re-request your review.

@BNAndras BNAndras dismissed iHiD’s stale review March 3, 2025 19:14

Changes to slug and UUID have been undone.

@BNAndras BNAndras merged commit 28ff34b into exercism:main Mar 3, 2025
7 checks passed
@BNAndras BNAndras added x:action/fix Fix an issue x:action/sync Sync content with its latest version x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation labels Mar 3, 2025
@iHiD
Copy link
Member

iHiD commented Mar 4, 2025

Yes. Sorry... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue x:action/sync Sync content with its latest version x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants