-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roman Numerals] Draft of Approaches #3605
Conversation
I think my latest changes get the directory structure about right, and linting now passes. There are still a small number of TODOs in the markdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all nits, so feel free to ignore any irritating ones.
The only "must change" is the TODO - otherwise, this looks good to go! 🌈 🌟
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/recurse-match/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/recurse-match/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/recurse-match/content.md
Outdated
Show resolved
Hide resolved
Didn't register your question at first - apologies!
Would the equivalent be a |
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Don't worry, I moved past that in the most recent commit. I thought about it and left it out. Feel free to add it back in if you want to, but it doesn't excite me. |
…n into approach-roman-numerals
With an analysis added for |
Found a mistake already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for not getting to this until now. Looks good save for two small niggles. Thanks for writing this! 🌟
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Outdated
Show resolved
Hide resolved
Pushing the big green button! |
Don't take this too seriously yet, it's clearly incomplete and I'll push updates when I have them. The empty files will also make it fail the CI checks, I expect - whatever, it's not for merging.
If you run out of rabbit holes to get lost down, take a look at the
with-itertools
approach. Somebody clearly had fun coming up with the most cryptic code possible, so explaining it is a challenge that I'm still working on (not as the most urgent priority).There are a couple of placeholders:
pattern-matching
from Scalafold-list
from KotlinI expect we could come up with Python versions of these, but I have some doubts about whether it's worthwhile. Thoughts?