Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roman Numerals] Draft of Approaches #3605

Merged
merged 19 commits into from
Jan 31, 2024

Conversation

colinleach
Copy link
Contributor

Don't take this too seriously yet, it's clearly incomplete and I'll push updates when I have them. The empty files will also make it fail the CI checks, I expect - whatever, it's not for merging.

If you run out of rabbit holes to get lost down, take a look at the with-itertools approach. Somebody clearly had fun coming up with the most cryptic code possible, so explaining it is a challenge that I'm still working on (not as the most urgent priority).

There are a couple of placeholders:

  • pattern-matching from Scala
  • fold-list from Kotlin

I expect we could come up with Python versions of these, but I have some doubts about whether it's worthwhile. Thoughts?

@colinleach
Copy link
Contributor Author

I think my latest changes get the directory structure about right, and linting now passes.

There are still a small number of TODOs in the markdown.

@colinleach colinleach changed the title [Roman Numerals] early draft of approaches [Roman Numerals] draft of approaches Jan 28, 2024
@colinleach colinleach changed the title [Roman Numerals] draft of approaches [Roman Numerals] Draft of Approaches Jan 28, 2024
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all nits, so feel free to ignore any irritating ones.

The only "must change" is the TODO - otherwise, this looks good to go! 🌈 🌟

@BethanyG
Copy link
Member

Didn't register your question at first - apologies!

fold-list from Kotlin

Would the equivalent be a functools.reduce() or maybe a filter() or itertools.compress()? I will think on it after I finish up Raindrops.

colinleach and others added 10 commits January 29, 2024 20:25
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@colinleach
Copy link
Contributor Author

Didn't register your question at first

Don't worry, I moved past that in the most recent commit. I thought about it and left it out. Feel free to add it back in if you want to, but it doesn't excite me.

@colinleach
Copy link
Contributor Author

With an analysis added for itertools-starmap I think I've now fixed all the problems I know about. Over to you to find more....

Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not getting to this until now. Looks good save for two small niggles. Thanks for writing this! 🌟

@BethanyG
Copy link
Member

Pushing the big green button!

@BethanyG BethanyG merged commit 4e69833 into exercism:main Jan 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants