[Black Jack]: Comparisons Concept and Concept Exercise Finalization

[BethanyG]

Added/Changed/Edited files:

• config.json
• exercises/concept/black-jack/.meta/config.json

---

• concepts/comparisons/introduction.md
• concepts/comparisons/about.md

---

• exercises/concept/black-jack/.docs/introduction.md
• exercises/concept/black-jack/.docs/instructions.md
• exercises/concept/black-jack/.docs/hints.md

---

• exercises/concept/black-jack/.meta/exemplar.py
• exercises/concept/black-jack/black_jack.py
• exercises/concept/black-jack/black_jack_test.py

[github-actions]

Hi & Welcome! 👋🏽 👋

Thank you for contributing to exercism/python 💛 💙 -- we really appreciate it! 🌟 🌈

This is an automated [🤖 🤖  ] comment for the maintainers of this repository, notifying them of your contribution. 🎉
Someone will review/reply to your changes shortly. (usually within 72 hours.)
You can safely ignore the maintainers section below.

⚠️  Please be aware ⚠️

     This repo does not generally accept Pull Requests unless they follow our contributing guidelines and are:

     1️⃣     Small, contained fixes for typos/grammar/punctuation/code syntax on [one] exercise,
     2️⃣     Medium changes that have been agreed/discussed via a filed issue,
     3️⃣     Contributions from our [help wanted][help-wanted] issue list,
     4️⃣     Larger (previously agreed-upon) contributions from recent & regular (within the last 6 months) contributors.

    Pull Requests not in these categories will be closed. 😞

---

💙 It looks like you are changing/adding files in a Concept Exercise! 💙

‼️  Did You...

Update & rebase your branch with any (recent) upstream changes.  Spell and grammar check all prose changes.  Run Prettier on all markdown and JSON files. (Optionally) run yapf (yapf config) to help format your code.  Run flake8 with flake8 config to check general code style standards.   Run pylint with pylint config to check extended code style standards.  Use pytest or the python-track-test-runner to test any changed example.py/exemplar.pyfiles  against their associated test files.  Similarly, use pytest or the python-track-test-runner to test any changed test files. Check that tests fail properly, as well as succeed.  (e.g., make some tests fail on purpose to "test the tests" & failure messages).  Double-check all files for proper EOL.  Regenerate exercise documents when you modified or created a hints.md file for a practice exercise.  Regenerate the test file if you modified or created a JinJa2 template file for a practice exercise. Run the generated test file result against its example.py.  Run configlet-lint if the track config.json, or any other exercise config.json has been modified.

✅️  Have You Checked:

. Are there any additional changes you need to make? Please make sure all associated files are present and consistent with your changes! Concept Exercise Anatomy .docs/hints.md .docs/instructions.md .docs/introduction.md .meta/config.json .meta/design.md .meta/exemplar.py (exemplar solution) <exercise-slug>_test.py (test file) <exercise-slug>.py (stub file) concepts/../introduction.md concepts/../about.md concepts/../links.json concepts/../.meta/config.json

🛠️    Maintainers   

Please take note 📒 of the following sections/review items 👀 ✨

🌈  Acknowledgements and Reputation

❓ Does this PR need to receive a label with a reputation modifier? medium is awarded by default. ❓ Does this contributor need to be added to the exercise authors or contributors? ❓ Does this contributor need to be added to the concept authors or contributors? ❓ Is there an associated issue or issues that should be linked to this PR?

💫  General Code Quality

Verify:  The branch was updated & rebased with any (recent) upstream changes.  All prose was checked for spelling and grammar.  Files are formatted via yapf (yapf config) & conform to our coding standards  Files pass flake8 with flake8 config & pylint with pylint config.  Changed example.py/exemplar.py files still pass their associated test files.  Changed test files still work with associated example.py/exemplar.py files. Check that tests fail properly, as well as succeed. (e.g., make some tests fail on purpose to "test the tests" & failure messages).  All files have proper EOL.  If a JinJa2 template was modified/created, was the test file regenerated? Does the regenerated test file successfully test the exercises example.py file?  The branch passes all CI checks & configlet-lint.

🌿  Changes to Concept Exercises

• ❓ Are all required files still up-to-date & configured correctly for this change?_
• ❓ Does <exercise>/.meta/design.md need to be updated with new implementation/design decisions
• ❓ Do these changes require follow-on/supporting changes to related concept documents?

✨  Where applicable, check the following ✨




(as a reminder: Concept Exercise Anatomy) Exercise introduction.md Do all code examples compile, run, and return the shown output? Are all the code examples formatted per the Python docs? Exercise instructions.md Exercise hints.md Check that exercise design.md was fulfilled or edited appropriately Exercise exemplar.py Only uses syntax previously introduced or explained. Is correct and appropriate for the exercise and story. Exercise <exercise_name>.py (stub) Includes appropriate docstrings and function names. Includes pass for each function Includes an EOL at the end Exercise <exercise_name>_test.py Tests cover all (reasonable) inputs and scenarios At least one test for each task in the exercise If using subtests or fixtures they're formatted correctly for the runner Classnames are <ExerciseName>Test Test functions are test_<test_name> Exercise config.json --> valid UUID4 Corresponding concept introduction.md Corresponding concept about.md Concept config.json All Markdown Files : Prettier linting (for all markdown docs) All Code files: PyLint linting (except for test files) All files with text: Spell check & grammar review.

🚀  Changes to Practice Exercises

Is the exercise is in line with Practice Exercise Anatomy? .docs/instructions.md(required) Was this file updated and regenerated properly? .docs/introduction.md(optional) .docs/introduction.append.md(optional) .docs/instructions.append.md (optional) Are any additional instructions needed/provided?  (e.g. error handling or information on classes) .docs/hints.md(optional) Was this file regenerated properly? .meta/config.json (required) .meta/example.py (required) Does this pass all the current tests as written/generated? .meta/design.md (optional) .meta/template.j2 (template for generating tests from canonical data) Was a test file properly regenerated from this template? .meta/tests.toml Are there additional test cases to include or exclude? Are there any Python-specific test cases needed for this exercise? <exercise-slug>_test.py Does this file need to be regenerated? Does this file correctly test the example.py file? Does this file correctly report test failures and messages? <exercise-slug>.py (required) Does this stub have enough information to get  the student started coding a valid solution?

🐣  Brand-New Concept Exercises

Is the exercise is in line with Concept Exercise Anatomy? Exercise introduction.md Do all code examples compile, run, and return the shown output? Are all the code examples formatted per the Python docs? Exercise instructions.md Exercise hints.md Check that exercise design.md was fulfilled or edited appropriately Exercise exemplar.py Only uses syntax previously introduced or explained. Is correct and appropriate for the exercise and story. Exercise <exercise_name>.py (stub) Includes appropriate docstrings and function names. Includes pass for each function Includes an EOL at the end Exercise <exercise_name>_test.py Tests cover all (reasonable) inputs and scenarios At least one test for each task in the exercise If using subtests or fixtures they're formatted correctly for the runner Classnames are <ExerciseName>Test Test functions are test_<test_name> Exercise config.json --> valid UUID4 Corresponding concept introduction.md Corresponding concept about.md Concept config.json All Markdown Files : Prettier linting (for all markdown docs) All Code files: Flake8 & PyLint linting All Code Examples: proper formatting and fencing. Verify they run in the REPL All files with text: Spell check & grammar review.

Our   💖   for all your review efforts! 🌟 🦄

[kotp]

Looking pretty good, but I think there may have been some unintended changes, plus what appears to be style deviance instances in the documents themselves.

And a question about <apples> and <oranges>.

[BethanyG]

Alrighty. Ran everything through priettier, and cleaned up the <apples> and <oranges> 😉 I also removed the excess lines in the module docstrings. Let me know if there's anything I've missed. 😄 Thanks for reviewing this!

[BethanyG]

@kotp - are there additional changes needed here for approval? Let me know - thanks!

[kotp]

I approve, as long as <fish> is valid Python. I kind of think it may be confusing if the student plus that in and it does not work. And then has to interpret it more as Unix documentation style for the meanings of those brackets.

[BethanyG]

I have no bead on if <fish> is going to be confusing. The convention is used in many Python concept exercises to denote a placeholder variable or parameter, to signal to the student that the name can really be anything they want.

My thought is to have the exercise go live in beta mode, and if it is confusing to students they will (loudly) let us know - and we can discuss re-working it at that point.

[kotp]

On 22/01/08 10:27AM, BethanyG wrote: I have no bead on if `<fish>` is going to be confusing. The convention is used in many Python concept exercises to denote a placeholder variable or parameter, to signal to the student that the _name_ can really be anything they want.

Also, if it has been being used, and understood well, already, then I do not have a problem with it.

My thought is to have the exercise go live in `beta` mode, and if it is confusing to students they will (loudly) let us know - and we can discuss re-working it at that point.

Definitely. I do not know if this is common outside of the Python track, and used widely in the Python greater community. As an "outsider" I definitely that as a perspective. But if it is convention in the Python community, then it should be used here as well, as the student will learn that this is not something unique in how this is communicated on Exercism.