Skip to content

Add Sets Concept Documents #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 13, 2021
Merged

Add Sets Concept Documents #2476

merged 8 commits into from
Aug 13, 2021

Conversation

BethanyG
Copy link
Member

Created the following docs for the set concept:

  • concepts/sets/.meta/config.json
  • concepts/sets/about.md
  • concepts/sets/introduction.md
  • concepts/sets/links.json
  • exercises/concept/sets/.meta/design.md

@BethanyG BethanyG added the x:size/large Large amount of work label Jul 21, 2021
@BethanyG BethanyG requested a review from a team July 21, 2021 02:59
@BethanyG BethanyG changed the title Created Sets Concept Documents Add Sets Concept Documents Jul 21, 2021
@BethanyG
Copy link
Member Author

Linting is failing due to /home/runner/work/python/python/exercises/shared/.docs. #2475 needs to be merged ahead of this PR to correct that problem (I think).

@kotp
Copy link
Member

kotp commented Aug 12, 2021

Linting is failing due to /home/runner/work/python/python/exercises/shared/.docs. #2475 needs to be merged ahead of this PR to correct that problem (I think).

That is merged, still a problem with the CI?

kotp
kotp approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some extra newlines, more than what seems to be the style in areas. Not a reason to deny, but I wanted to mention it, if it is worth standardizing that.

@BethanyG
Copy link
Member Author

There seems to be some extra newlines, more than what seems to be the style in areas. Not a reason to deny, but I wanted to mention it, if it is worth standardizing that.

Thanks for the review. 😄 I'll take a look at the newlines across exercises at some point. Most of the content needs to be re-edited to a shorter length anyways.

That is merged, still a problem with the CI?

Yeah - there was a late addition to this PR for links.json, so I needed to do a 3-way merge locally and force an update. Things look ok now tho.

@BethanyG BethanyG merged commit b90c3fe into exercism:main Aug 13, 2021
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp approved these changes

Assignees
No one assigned
Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BethanyG @kotp