-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PR2429 Reconstruction] #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR2429 Reconstruction] #2443
Conversation
Thank you @neenjaw! 😄 |
@iHiD / @ErikSchierboom -- on review, flagging this as major. Since this is a reproduction of PR 2429, extra rep should also go to @sachsom95 for both the original exercise, and extra review on the re-write. |
(We have no way to automatically retrospectively append these reps, but if you make me a list across all the PRs, I'll manually go through and add them all at ETL time?) |
If I get a list of repo/PR number/label, I can do that automatically. |
Thanks -- I'll make sure to add this to my "do before launch" list. 😄 |
Reconstructed PR2429, so that the ugly merge commit files were omitted. This PR should be "clean" and only include the additions/edits relating to the
Meltdown Mitigation
(conditionals) concept exercise 'cleanup':Renamed exercise to
Meltdown Mitigation
. Stub files reman asconditionals.py
andconditionals_test.py
.introduction.md
instructions.md
hints.md
exemplar.py
conditionals_test.py
conditionals.py
/.meta/links.json
filemeltdown-mitigation
to trackconfig.json
.meta/config.json
filePlease Note: @sachsom95 and @neenjaw gave feedback on the original PR, so should have credit for review here as well.