Skip to content

[PR2429 Reconstruction] #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2021
Merged

[PR2429 Reconstruction] #2443

merged 8 commits into from
May 30, 2021

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented May 30, 2021

Reconstructed PR2429, so that the ugly merge commit files were omitted. This PR should be "clean" and only include the additions/edits relating to the Meltdown Mitigation (conditionals) concept exercise 'cleanup':

Renamed exercise to Meltdown Mitigation. Stub files reman as conditionals.py and conditionals_test.py.

  • Rewrote introduction.md
  • Rewrote instructions.md
  • Created hints.md
  • Created exemplar.py
  • Checked and edited conditionals_test.py
  • Added docstrings to conditionals.py
  • Added a /.meta/links.json file
  • Added meltdown-mitigation to track config.json
  • Formatted .meta/config.json file
  • Ran prettier

Please Note: @sachsom95 and @neenjaw gave feedback on the original PR, so should have credit for review here as well.

@BethanyG
Copy link
Member Author

Thank you @neenjaw! 😄

@BethanyG BethanyG merged commit bc3be67 into exercism:main May 30, 2021
@BethanyG
Copy link
Member Author

@iHiD / @ErikSchierboom -- on review, flagging this as major. Since this is a reproduction of PR 2429, extra rep should also go to @sachsom95 for both the original exercise, and extra review on the re-write.

@iHiD
Copy link
Member

iHiD commented Jun 16, 2021

(We have no way to automatically retrospectively append these reps, but if you make me a list across all the PRs, I'll manually go through and add them all at ETL time?)

@ErikSchierboom
Copy link
Member

If I get a list of repo/PR number/label, I can do that automatically.

@BethanyG
Copy link
Member Author

Thanks -- I'll make sure to add this to my "do before launch" list. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants