-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added Icons for Concept Exercises. #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neenjaw
approved these changes
May 29, 2021
@iHiD Reviewers approval doesn't seem to allow merge. Do I need to edit the CODEOWNERS file, or is there a different permission that needs to be added? |
See #2433 (comment) |
Co-authored-by: Tim Austin <tim@neenjaw.com>
Co-authored-by: Tim Austin <tim@neenjaw.com>
Co-authored-by: Tim Austin <tim@neenjaw.com>
Suggestions/corrections/edits from code review. Co-authored-by: Tim Austin <tim@neenjaw.com>
added escape character example.
added three step examples per suggestions on code review.
…exemplars and stub files where needed.
* Created about, introduction and links files. * Added authors and blurb info for conditionals concept. * Created about, introduction and links files. * Added authors and blurb info for conditionals concept. * Apply suggestions from code review Applied suggestions/edits/corrections from code review. Co-authored-by: Tim Austin <tim@neenjaw.com> * Apply suggestions from code review Applied suggestions/edits/corrections from code review. * Attempted to remove hidden CLRF chars in code example. May have failed. Co-authored-by: Tim Austin <tim@neenjaw.com>
…b and exmeplar files.
…concep docs edits.
…thon into exercise-icon-patrol resolving merge conflics in PR2431
Like 2429, this picked up codeowners changes. Apologies, everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
black-jack
card-games
chaitanas-colossal-coaster
currency-exchange
ghost-gobble-arcade-game
guidos-gorgeous-lasagna/
inventory-management
little-sisters-essay
log-levels
making-the-grade
pretty-leaflet
processing-logs
restaurant-rozalynn
sets
tisbury-treasure-hunt