Skip to content

Added Icons for Concept Exercises. #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 41 commits into from

Conversation

BethanyG
Copy link
Member

Includes

  • black-jack
  • card-games
  • chaitanas-colossal-coaster
  • currency-exchange
  • ghost-gobble-arcade-game
  • guidos-gorgeous-lasagna/
  • inventory-management
  • little-sisters-essay
  • log-levels
  • making-the-grade
  • pretty-leaflet
  • processing-logs
  • restaurant-rozalynn
  • sets
  • tisbury-treasure-hunt

@BethanyG BethanyG requested a review from a team as a code owner May 15, 2021 02:34
@BethanyG BethanyG requested a review from cmccandless May 21, 2021 00:25
@BethanyG BethanyG requested review from a team and removed request for cmccandless May 28, 2021 16:56
@BethanyG
Copy link
Member Author

@iHiD Reviewers approval doesn't seem to allow merge. Do I need to edit the CODEOWNERS file, or is there a different permission that needs to be added?

@iHiD
Copy link
Member

iHiD commented May 29, 2021

See #2433 (comment)

BethanyG and others added 20 commits May 29, 2021 16:12
Co-authored-by: Tim Austin <tim@neenjaw.com>
Co-authored-by: Tim Austin <tim@neenjaw.com>
Suggestions/corrections/edits from code review.

Co-authored-by: Tim Austin <tim@neenjaw.com>
added three step examples per suggestions on code review.
BethanyG and others added 18 commits May 29, 2021 16:17
* Created about, introduction and links files.

* Added authors and blurb info for conditionals concept.

* Created about, introduction and links files.

* Added authors and blurb info for conditionals concept.

* Apply suggestions from code review

Applied suggestions/edits/corrections from code review.

Co-authored-by: Tim Austin <tim@neenjaw.com>

* Apply suggestions from code review

Applied suggestions/edits/corrections from code review.

* Attempted to remove hidden CLRF chars in code example.  May have failed.

Co-authored-by: Tim Austin <tim@neenjaw.com>
…thon into exercise-icon-patrol

resolving merge conflics in PR2431
@BethanyG BethanyG requested a review from a team as a code owner May 30, 2021 02:30
@BethanyG
Copy link
Member Author

Like 2429, this picked up codeowners changes. Apologies, everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants