Skip to content

Add Pedro Romano to maintainers. #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmccandless merged 1 commit into from
Jan 17, 2020
Merged

Add Pedro Romano to maintainers. #2163

cmccandless merged 1 commit into from
Jan 17, 2020

Conversation

@paparomeo
Copy link
Contributor

@paparomeo paparomeo commented Jan 16, 2020

👋

@paparomeo paparomeo requested a review from a team as a code owner January 16, 2020 00:33
cmccandless
cmccandless suggested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a script (configlet fmt) that enforces styling on config.json and config/maintainers.json. You have a typo in your entry, so Travis CI failed. Please apply this suggested change and we should be good to go.

@paparomeo paparomeo force-pushed the add-paparomeo-to-maintainers branch from 4196621 to 3a8f516 Compare January 16, 2020 22:22
@paparomeo paparomeo force-pushed the add-paparomeo-to-maintainers branch from 3a8f516 to 46da7d2 Compare January 16, 2020 22:24
@paparomeo
Copy link
Contributor Author

paparomeo commented Jan 16, 2020

Rebased and fixed @cmccandless, Apologies for not checking if the build was passing.

@cmccandless cmccandless merged commit e3e96da into exercism:master Jan 17, 2020
@cmccandless
Copy link
Contributor

cmccandless commented Jan 17, 2020

Merged; Welcome!

For future reference, suggested changes in PRs can be committed directly in GitHub, and commits can be squashed at merge time, so you don't usually need to force-push your branch.

@paparomeo
Copy link
Contributor Author

paparomeo commented Jan 17, 2020

Thank for merging!

For future reference, suggested changes in PRs can be committed directly in GitHub, and commits can be squashed at merge time, so you don't usually need to force-push your branch.

Yes, I'm aware, I'm just a bit pedantic about my git history. Thanks for pointing it out, though.

@paparomeo paparomeo deleted the add-paparomeo-to-maintainers branch January 17, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cmccandless cmccandless cmccandless approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paparomeo @cmccandless