Skip to content

Remove broken link in grade school. fixes #2040 #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2022
Merged

Conversation

ceddlyburge
Copy link
Contributor

No description provided.

@jiegillet jiegillet merged commit 05999f3 into main May 21, 2022
@jiegillet jiegillet deleted the ceddlyburge-patch-1 branch May 21, 2022 05:34
@ceddlyburge
Copy link
Contributor Author

Hi @SaschaMann @ErikSchierboom this change fails the configlet CI check when I sync it in to the Elm repository.
https://github.com/exercism/elm/runs/6536869034?check_suite_focus=true

Can we fix this by just removing source, or will we need to update configlet?

Thanks, Cedd

@ee7
Copy link
Member

ee7 commented May 21, 2022

@ceddlyburge Ah. It turns out that configlet sync doesn't properly handle a key/value pair that was removed.

I'll fix configlet so that configlet sync -u removes a source or source_url property (rather than setting the value to the empty string) from an exercise's .meta/config.json if the corresponding key was removed in problem-specifications.

For now, please remove source_url manually.


I've checked that this PR was the first time we've removed a source or source_url key since Exercism v3. That's why we didn't hit this edge case for configlet sync before.

cd /tmp
git clone https://github.com/exercism/problem-specifications
cd problem-specifications
git checkout 05999f3
git log --oneline -- 'exercises/*/metadata.toml'
  • 05999f3 Remove broken link in grade school. fixes #2040
  • 7cd0ab1 Add exercise: killer-sudoku-helper
  • 3e1cfcb Add exercise: state-of-tic-tac-toe
  • 2b039c3 Fix bowling game copy
  • d2a4b3e Two-fer: add title to metadata
  • df6420b Convert exercise metadata from yaml to toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants