updated minesweeper canonical data to contain borders

[sprinkle24]

No description provided.

[sshine]

Interesting addition. Is there a prior discussion of this?

I think this falls under the category of improvements that are held back by #1560.

[sprinkle24]

Ok, I found this issue: #1555
did not know it was blocked :).

[petertseng]

when merging, please amend the commit messages to:

• Link to the issue minesweeper tests do not contain border #1555
• Summarise the reason for the change in this commit message. A short summary such as "So that the description and the tests are consistent" will be acceptable.

Please also see two comments on the tests

[petertseng]

The problem-specifications reviewers should also decide: Should there be tests for an invalid border? Here are some possible outcomes I see:

• Yes, but they should be in a different PR. An issue should be created.
• Yes, and they must be in this PR before it is merged.
• No, and this PR should change the description to state that the border will always be valid.
• No, and no description change is necessary (AKA, tracks are able to add them if desired, but we won't place them in the file here).

I have no preference and will default to the last option if no other preferences are stated.

[sprinkle24]

when merging, please amend the commit messages to:

• Link to the issue minesweeper tests do not contain border #1555
• Summarise the reason for the change in this commit message. A short summary such as "So that the description and the tests are consistent" will be acceptable.

Please also see two comments on the tests

Done.

[sprinkle24]

Solved the two requested changes.

the requests are done

[yawpitch]

I'm going to strongly suggest that this change is unnecessary and does nothing but increases the complexity of the solution without markedly increasing its value as a learning exercise.

As is the student need only consider a binary state for a given place on the board -- does it contain a mine, or no -- and the area outside the playing board needs to merely be ignored. With these changes the student needs to also consider three potential wall tiles, and also whether or not the border itself is properly formed.

As an aesthetic choice it might make sense to display a minesweeper board with a border, but it doesn't make sense to transmit one with that border.

So my vote would be for updating the description.md file to reflect the fact that the border in that file is for display purposes only and has no bearing on the problem.