Skip to content

leap 1.4.0: Add negative test: year divisible by 200, not divisible by 400 #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Conversation

sshine
Copy link
Contributor

@sshine sshine commented Oct 8, 2018

Someone thought they could write year mod 200 = 0. Test didn't fail.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem this is necessary. another alternative would have to change the 2100 to an 1800, but the purpose of each case may become unclear if each case starts to test too many things!

Someone thought they could write `year mod 200 = 0`. Test didn't fail.
@sshine sshine merged commit 7ac9975 into exercism:master Oct 9, 2018
petertseng pushed a commit to exercism/haskell that referenced this pull request Oct 9, 2018
…y 400 (#733)

Addresses exercism/problem-specifications#1359

Previously, an implementation of `year mod 200 = 0` didn't fail!
matthewmorgan pushed a commit to exercism/javascript that referenced this pull request Oct 20, 2018
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Nov 1, 2018
Someone thought they could write `year mod 200 = 0`. Test didn't fail.

exercism/problem-specifications#1359
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants