Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Mistake in Custom Set exercise test suite #401

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

glaxxie
Copy link
Contributor

@glaxxie glaxxie commented Oct 19, 2024

Fix a mistake from test suite
"set is equal to a set constructed from an array with duplicates" should be true instead of false
Examplar file also edited to reflect the change.

Fix a mistake from test suite
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Changes  made to example file and the test suite
@glaxxie glaxxie changed the title Update CustomSet.tests.ps1 [Fix]: Mistake in Custom Set exercise test suite Oct 19, 2024
@glaxxie glaxxie added x:action/fix Fix an issue x:rep/tiny Tiny amount of reputation labels Oct 19, 2024
@glaxxie glaxxie assigned glaxxie and unassigned glaxxie Oct 19, 2024
@glaxxie glaxxie merged commit f951e8d into main Oct 20, 2024
3 checks passed
@glaxxie glaxxie deleted the ps-custom-set-typo branch October 20, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants