Skip to content

Flip assertEqauls() arguments #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2021
Merged

Flip assertEqauls() arguments #358

merged 1 commit into from
Mar 27, 2021

Conversation

zembrowski
Copy link
Contributor

@neenjaw
Copy link
Collaborator

neenjaw commented Mar 26, 2021

Thanks for opening a PR to help improve the PHP track!

I'll need to check more closely, but I think this work is already being done in an open PR in #357 by @codedge which was opened 2 days ago.

If it isn't overlapping I'll take a look at this tonight to review it.

@neenjaw neenjaw self-requested a review March 27, 2021 03:25
@neenjaw
Copy link
Collaborator

neenjaw commented Mar 27, 2021

Awesome! I think @codedge missed part of this meetup test file, which your PR covers! Most appreciated!!

@neenjaw neenjaw merged commit 04c4db1 into exercism:main Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neenjaw neenjaw neenjaw approved these changes

Assignees
No one assigned
Labels
reputation/contributed_code/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zembrowski @neenjaw