Skip to content

Make configlet lint pass all checks #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tejasbubane
Copy link
Member

@tejasbubane tejasbubane commented Feb 5, 2021

Related #961

  1. Add solution and spec files for elyses-transformative-enchantments exercise.
  2. Fix all other minor configlet lint issues.

@tejasbubane tejasbubane force-pushed the configlet-lint branch 2 times, most recently from 99d4b91 to 275c71f Compare February 5, 2021 20:27
@tejasbubane tejasbubane force-pushed the configlet-lint branch 2 times, most recently from 261d288 to 275c71f Compare February 5, 2021 20:48
@tejasbubane
Copy link
Member Author

tejasbubane commented Feb 5, 2021

Looks like the CI scripts need to be fixed for new v3 directory structure (exercises/concept, exercises/practice). I'll give it a try tomorrow.

@SleeplessByte
Copy link
Member

SleeplessByte commented Feb 6, 2021

@tejasbubane yes, when you're add it, example.js in practice exercises should move to .meta/proof.ci.js. example.js in concept exercises should become .meta/exemplar.js (not example.js).

I can make this change if you fix the CI, or you can do it in one go 🗡️

It's semi-important that they go into .meta, due to what the CLI will send to students in v3.

@ee7

This comment has been minimized.

@ErikSchierboom

This comment has been minimized.

@ErikSchierboom

This comment has been minimized.

@SleeplessByte
Copy link
Member

SleeplessByte commented Feb 24, 2021

I have an hour time right now, so I'm checking out your branch and seeing if I can resolve this.

@SleeplessByte
Copy link
Member

Superseeded by #997

@tejasbubane tejasbubane deleted the configlet-lint branch March 4, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants