-
-
Notifications
You must be signed in to change notification settings - Fork 637
Use @exercism/babel-preset-javascript #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SleeplessByte Where is the code for |
I don't have a repo yet! You can pull the file directly from npm. It's just a single file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some more questions to be sure this works.
-
The code in
@exercism/babel-preset-javascript
contains presets and an empty plugins array and then the babel.config.js file containspresets
and and empty plugins array again. Is that correct/intended? -
When corejs was updated in the past, you said we also need to update the babel.config.js file. Does this mean after this change e.g. when @tejasbubane want's to merge the update, he would need to update the new npm package first (which is currently impossible for him) and then include the updated version in the repo and update the corejs version in the repo?
-
I thought we had CI to check that the corejs version in the babel.config.js fits the one in the package.json. Probably this CI check needs to be changed/removed now (even if it might not fail if the corejs key can't be found.
CI did not run for this, I will try close and re-open. |
Good questions!
|
284cfef
to
97c8f4b
Compare
This uses
@exercism/babel-preset-javascript
for the babel configuration.Technically this also opens up
@exercism/babel-plugin-javascript
, should we ever want some custom shit, including injecting stuff for the test-runner.