Skip to content

Rename conept exercise dirs: closures and recursion #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2021
Merged

Rename conept exercise dirs: closures and recursion #1237

merged 10 commits into from
Aug 22, 2021

Conversation

angelikatyborska
Copy link
Member

I noticed that there still are some concept exercises that are in directories named after concepts.

This PR renames:

  • closures -> coordinate-transformation
  • recursion -> pizza-order

There are 3 non-story directory names remaining, but I am not touching them:

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to fix more in those exercises, so putting it on hold

@angelikatyborska
Copy link
Member Author

In recursion yes, there's an issue: #945

closures looks pretty complete to me, except for the blurb.

Are you sure not merging this on its own is the best strategy? I'm not really volunteering to fix recursion so somebody would either need to branch off my branch or just redo the same changes. I don't really see any harm in merging just the dir renames.

@SleeplessByte
Copy link
Member

It's a good indication currently on if it's old or not :p.

That's my only concern.

I can probably make time this weekend.

@SleeplessByte
Copy link
Member

Narrator: I didn't

@junedev
Copy link
Member

junedev commented Aug 21, 2021

@angelikatyborska I discussed with @SleeplessByte that I will have look whether anything else needs to be fixed.

@junedev junedev self-assigned this Aug 21, 2021
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @SleeplessByte that we put the recursion exercise back to "wip" for now because too many things are missing.

Added some more small fixes and the missing blurbs.

@junedev junedev merged commit 4b742af into exercism:main Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants