Skip to content

Add concept exercise functions #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 11, 2021
Merged

Add concept exercise functions #1183

merged 23 commits into from
Aug 11, 2021

Conversation

junedev
Copy link
Member

@junedev junedev commented Jun 16, 2021 •
edited
Loading

Closes #994

ℹ️ Notes

  • Note that some parts of the original issue (e.g. writing an extensive about.md) were transferred into a new issue to get the main parts out of the door quickly before v3 launch. See Improve Concept Exercise: Functions (Lasagna Master) #1234.
  • I left the stub file empty for this exercise because it is about writing functions so providing the function signatures already wouldn't make sense. Instead I put in a comment reminding the student about the format how to export functions so they don't forget about that.
  • The PR includes removing an empty and unused concept that was called variable-parameters.

@junedev junedev requested a review from a team July 31, 2021 18:44
@junedev junedev added x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:size/large Large amount of work x:type/content Work on content (e.g. exercises, concepts) labels Jul 31, 2021
@junedev junedev marked this pull request as ready for review August 5, 2021 18:34
angelikatyborska
angelikatyborska approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@angelikatyborska angelikatyborska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing a guests review per @junedev request because @SleeplessByte is busy 🙂

I read all of the documents and tests. I think the exercise is very well written and provides all the information necessary to solve it.

exercises/concept/lasagna-master/lasagna-master.spec.js Outdated
carrots: 1,
mozzarella: 0.5,
ricotta: 50,
béchamel: 0.1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE gives me a warning here:
Screen Shot 2021-08-07 at 10 04 32

Could it be a problem for some students on some machines? Should the key be wrapped in ''?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key should be wrapped indeed 🗡️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SleeplessByte I had quotes at some point but prettier/eslint removed them. No matter whether I only quote that one key or all of them. Do you have the same behavior? If yes, any idea how to fix this "globally" instead of ignore rules here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added prettier-ignore and quotes for now until we find a proper fix

SleeplessByte
SleeplessByte approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angelika already did a great job reviewing. All my comments are additional, but overall I think this is good to go. Was a lot of fun reading. Great job!

exercises/concept/lasagna-master/lasagna-master.spec.js Outdated
carrots: 1,
mozzarella: 0.5,
ricotta: 50,
béchamel: 0.1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key should be wrapped indeed 🗡️

@junedev junedev merged commit e4655f2 into exercism:main Aug 11, 2021
@junedev junedev deleted the add-concept-exercise-functions branch August 11, 2021 14:28
@junedev junedev mentioned this pull request Aug 12, 2021
Merged
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

@angelikatyborska angelikatyborska angelikatyborska approved these changes

Assignees
No one assigned
Labels
x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:size/large Large amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[V3] Implement new Concept Exercise: Functions
3 participants
@junedev @SleeplessByte @angelikatyborska