-
-
Notifications
You must be signed in to change notification settings - Fork 637
Add ozans playlist concept exercise #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ozans playlist concept exercise #1093
Conversation
Sweet. I've invited @junedev to review as well as she has a great mental map of the concept-tree as we want it. As for the failing CI check, here is how you can resolve it: Either add a comment containing First bring your
Then sync it:
I will attempt to review it before Friday, but chat me up on Slack if you want faster feedback. |
The "Sync all exercises" action has started running. |
The "Sync all exercises" action has finished running. |
For security reasons,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not do a line-by-line review yet but from what I could glance this looks like great work. 🙂
I added some general comments that might be helpful.
6787d18
to
156e652
Compare
Marking this as ready to review, but further suggestions are certainly welcome! |
In concept exercises we don't skip tests because students don't have skipped tests on the web editor, so this makes it a similar experience via the CLI. They also don't see the tests on the web editor.
/format |
The "Format code" action has started running. |
The "Format code" action has finished running. |
For security reasons,
|
Thank you @junedev for all the wise words, and thank you @kristinaborn for this exercise. Let's merge it now and if we need changes make it in future PRs. |
@kristinaborn your exercise doesn't show up yet, likely because |
@SleeplessByte I'd love your thoughts on what I've got so far. It was surprisingly difficult to come up with a story for this one.
Hopefully I followed all the new guidelines correctly 🤞