-
-
Notifications
You must be signed in to change notification settings - Fork 637
[V3] Lucian's Lucious Lasagna: fix everything around this exercise #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
2d41ca0
Rename basics directory to lasagna
SleeplessByte 7bc2993
Rename lasagna exercise files
SleeplessByte 320a03b
Fix importing lasagna from the tests
SleeplessByte 67a067d
Add welcome block to basics exercise
SleeplessByte 546ed46
Fix directory and package name
SleeplessByte 1df5293
Match exemplar with stub
SleeplessByte beb6f6e
Fix lasagna config.json file references
SleeplessByte 6726e3b
Finetune instructions and introduction for basics exercise
SleeplessByte b408e41
Add contributors key (empty) for consistency
SleeplessByte 5c06579
Add emphasis where necessary
SleeplessByte 606e8a0
Add design document
SleeplessByte bf7cd1f
Update name in config.json
SleeplessByte 21e1698
Clean up basics concept
SleeplessByte f34a455
Add blurb for Basics
SleeplessByte 8fd1ed1
Apply suggestions from code review
SleeplessByte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,34 @@ | ||
[ | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Glossary/Primitive", | ||
"description": "mdn-primitive" | ||
}, | ||
{ | ||
"url": "https://en.wikipedia.org/wiki/Immutable_object", | ||
"description": "wiki-mutability" | ||
}, | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Glossary/Primitive", | ||
"description": "mdn-primitive" | ||
}, | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Glossary/Primitive", | ||
"description": "mdn-primitive" | ||
"description": "MDN Glossary: JavaScript Primitive" | ||
}, | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze", | ||
"description": "mdn-object-freeze" | ||
"description": "MDN: JavaScript Object freezing" | ||
}, | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules", | ||
"description": "mdn-module" | ||
"description": "MDN: JavaScript Module System" | ||
}, | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#Renaming_imports_and_exports", | ||
"description": "mdn-renaming-modules" | ||
"description": "MDN: Renaming modules when importing or exporting" | ||
}, | ||
{ | ||
"url": "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#Dynamic_Imports", | ||
"description": "mdn-dynamic-imports" | ||
"description": "MDN: JavaScript Dynamic imports" | ||
}, | ||
{ | ||
"url": "https://en.wikipedia.org/wiki/Immutable_object", | ||
"description": "About immutable objects" | ||
}, | ||
{ | ||
"url": "https://bitsofco.de/what-is-tree-shaking/", | ||
"description": "blog-tree-shaking" | ||
"description": "About tree shaking" | ||
}, | ||
{ | ||
"url": "https://2ality.com/2015/07/es6-module-exports.html#es6-modules-export-immutable-bindings", | ||
"description": "blog-live-bindings" | ||
"description": "About live bindings (JavaScript exports)" | ||
} | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.