Skip to content

largest-series-product: add to track #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2016
Merged

largest-series-product: add to track #173

merged 2 commits into from
Nov 14, 2016

Conversation

stkent
Copy link
Contributor

@stkent stkent commented Nov 11, 2016

No description provided.

@stkent stkent changed the title dibs: I will implement exercise largest-series-product largest-series-product: add to track Nov 12, 2016

public final class LargestSeriesProductCalculatorTest {

@Rule
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once discussion in #171 is complete, I will update with an appropriate comment to introduce the user to JUnit Rules here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you did it there was right on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold off on merging until you signal you're done with this part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment has now been added!

@jtigger
Copy link
Contributor

jtigger commented Nov 14, 2016

/me salutes @stkent.

@jtigger jtigger merged commit d677085 into exercism:master Nov 14, 2016
@stkent stkent deleted the largest-series-product branch November 14, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants