pov 1.1.1.3: simplify "Can find path from nodes other than x" #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm honestly not sure about the decisions I made, so take a look. |
This was the main change in exercism/problem-specifications#704 exercism/problem-specifications#710 is an inconsequential change that does not affect our tests. Two other changes in 1.1.0 that aren't exactly followed: * As a part of conforming to the canonical schema, trees were embedded into the test data, but we have no need to do it - let's reduce duplication, and besides we are safe from accidental mutation. * The "cannot trace" cases were changed to use simpler trees than cousins, but we would have had to introduce another tree to do that (one with kids and siblings). We'll stick with cousins.
rbasso
approved these changes
May 9, 2017
There was a problem hiding this comment.
- As a part of conforming to the canonical schema, trees were embedded into the test data, but we have no need to do it - let's reduce duplication, and besides we are safe from accidental mutation.
- The "cannot trace" cases were changed to use simpler trees than cousins, but we would have had to introduce another tree to do that (one with kids and siblings). We'll stick with cousins.
Considering that we are not algorithmically generating the test suites, It makes sense to reuse data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the main change in exercism/problem-specifications#704
exercism/problem-specifications#710 is an inconsequential
change that does not affect our tests.
Two other changes in 1.1.0 that aren't exactly followed:
into the test data, but we have no need to do it - let's reduce
duplication, and besides we are safe from accidental mutation.
cousins, but we would have had to introduce another tree to do that
(one with kids and siblings). We'll stick with cousins.